[pve-devel] [PATCH manager 3/3] ui: don't set the default value of combogrids to []

Dominik Csapak d.csapak at proxmox.com
Wed Jul 19 14:11:12 CEST 2023


the combogrid sets the default itself correctly

Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
depends on the widget-toolkit patch

 www/manager6/form/NodeSelector.js | 5 +----
 www/manager6/ha/GroupSelector.js  | 1 -
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/www/manager6/form/NodeSelector.js b/www/manager6/form/NodeSelector.js
index c3e3da31..bc282287 100644
--- a/www/manager6/form/NodeSelector.js
+++ b/www/manager6/form/NodeSelector.js
@@ -12,10 +12,7 @@ Ext.define('PVE.form.NodeSelector', {
 
     // only allow those nodes (array)
     allowedNodes: undefined,
-    // set default value to empty array, else it inits it with
-    // null and after the store load it is an empty array,
-    // triggering dirtychange
-    value: [],
+
     valueField: 'node',
     displayField: 'node',
     store: {
diff --git a/www/manager6/ha/GroupSelector.js b/www/manager6/ha/GroupSelector.js
index 61ab0c03..1823472f 100644
--- a/www/manager6/ha/GroupSelector.js
+++ b/www/manager6/ha/GroupSelector.js
@@ -2,7 +2,6 @@ Ext.define('PVE.ha.GroupSelector', {
     extend: 'Proxmox.form.ComboGrid',
     alias: ['widget.pveHAGroupSelector'],
 
-    value: [],
     autoSelect: false,
     valueField: 'group',
     displayField: 'group',
-- 
2.30.2






More information about the pve-devel mailing list