[pve-devel] [PATCH widget-toolkit/manager] improve combogrid default value handling

Dominik Csapak d.csapak at proxmox.com
Wed Jul 19 14:11:08 CEST 2023

the default value for combogrids is '', but we often need to set it to
[], to avoid issues with dirty tracking. Fix this by setting it to [] by
default, making it unnecessary to carry the workaround + comment around
in child classes.

the first patch of pve-manager is a bit unrelated but popped up during
development (can be applied independently)

the second patch of pve-manager is also a bit independent, but it fixes
wrong dirty tracking in the firewall rule edit window iff the widget
toolkit patch is also present

the third manager patch depends on the widget toolkit patch


Dominik Csapak (1):
  combogrid: initialze value with [] by default

 src/form/ComboGrid.js       | 2 +-
 src/form/NetworkSelector.js | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)


Dominik Csapak (3):
  ui: ipset: make ip/cidr required
  ui: don't set the default value of combogrids to ''
  ui: don't set the default value of combogrids to []

 www/manager6/form/NodeSelector.js  | 5 +----
 www/manager6/grid/FirewallRules.js | 2 --
 www/manager6/ha/GroupSelector.js   | 1 -
 www/manager6/panel/IPSet.js        | 2 +-
 4 files changed, 2 insertions(+), 8 deletions(-)


More information about the pve-devel mailing list