[pve-devel] [PATCH container] config permission check: also check access for currently configured bridge

Fiona Ebner f.ebner at proxmox.com
Mon Jul 17 09:15:17 CEST 2023


Relevant when modifying or removing an existing network device.

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
 src/PVE/LXC.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index a531ea5..1e9af0f 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -1316,7 +1316,8 @@ sub check_ct_modify_config_perm {
 	    $rpcenv->check_vm_perm($authuser, $vmid, $pool, ['VM.Config.Memory']);
 	} elsif ($opt =~ m/^net\d+$/) {
 	    $rpcenv->check_vm_perm($authuser, $vmid, $pool, ['VM.Config.Network']);
-	    PVE::LXC::check_bridge_access($rpcenv, $authuser, $newconf->{$opt});
+	    check_bridge_access($rpcenv, $authuser, $oldconf->{$opt}) if $oldconf->{$opt};
+	    check_bridge_access($rpcenv, $authuser, $newconf->{$opt}) if $newconf->{$opt};
 	} elsif ($opt eq 'nameserver' || $opt eq 'searchdomain' || $opt eq 'hostname') {
 	    $rpcenv->check_vm_perm($authuser, $vmid, $pool, ['VM.Config.Network']);
 	} elsif ($opt eq 'features') {
-- 
2.39.2






More information about the pve-devel mailing list