[pve-devel] [PATCH v2 guest-common 4/4] vzdump: schema: add 'pbs-entries-max' property
Fiona Ebner
f.ebner at proxmox.com
Fri Jul 7 15:13:46 CEST 2023
Am 15.06.23 um 16:14 schrieb Alexander Zeidler:
> Signed-off-by: Alexander Zeidler <a.zeidler at proxmox.com>
> ---
> Changes from v1:
> Improve description
> Move description to 'performance' section
> Remove arrow alignment
>
>
> src/PVE/VZDump/Common.pm | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/src/PVE/VZDump/Common.pm b/src/PVE/VZDump/Common.pm
> index a6fe483..83b715d 100644
> --- a/src/PVE/VZDump/Common.pm
> +++ b/src/PVE/VZDump/Common.pm
> @@ -88,6 +88,16 @@ PVE::JSONSchema::register_format('backup-performance', {
> default => 16,
> optional => 1,
> },
> + 'pbs-entries-max' => {
> + description => "Applies to file-based PBS backups. Increase it to enable backups of ".
Maybe add "Limits the number of entries allowed in memory at a given
time." as a second sentence?
Style nit: I think Thomas said he prefers the continuation dot on the
next line in a recent mail.
> + "folders with a large amount of files. The number adds up from the maximum path ".
> + "depth of a stored file/folder plus all antecedent file/folder siblings until ".
> + "there (but not their recursive files).",
IMHO, the last sentence is a bit hard to read. Maybe something like "For
a given file/folder, the number of entries required to hold in memory is
the sum of all file/folder siblings at each level in its path." is a bit
more straight-forward. Or did I misinterpret it :P?
> + type => 'integer',
> + minimum => 1,
> + default => 1048576,
> + optional => 1,
> + },
> });
>
> my $confdesc = {
More information about the pve-devel
mailing list