[pve-devel] [PATCH stable-7+master manager] ui: vm selector: handle empty string gracefully
Fiona Ebner
f.ebner at proxmox.com
Thu Jul 6 15:51:25 CEST 2023
which is passed by the backup job window when using selection mode
'all', would be converted to [""] and wrongly add an entry with VMID
0 because the item "" could not be found in the store.
Reported in the community forum:
https://forum.proxmox.com/threads/130164/
Fixes: 7a5ca76a ("fix #4239: ui: show selected but non-existing vmids in backup edit")
Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
www/manager6/form/VMSelector.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/form/VMSelector.js b/www/manager6/form/VMSelector.js
index 4c0bba13..bf2c8df7 100644
--- a/www/manager6/form/VMSelector.js
+++ b/www/manager6/form/VMSelector.js
@@ -162,7 +162,7 @@ Ext.define('PVE.form.VMSelector', {
setValue: function(value) {
let me = this;
if (!Ext.isArray(value)) {
- value = value.split(',');
+ value = value === '' ? [] : value.split(',');
}
let store = me.getStore();
--
2.39.2
More information about the pve-devel
mailing list