[pve-devel] [PATCH manager v2] fix #4364: pveceph: add confirmation dialogue for ceph installation

Max Carrara m.carrara at proxmox.com
Wed Jul 5 20:02:40 CEST 2023

Displays a confirmation dialogue if the user didn't explicitly
provide a valid ceph version via the `--version` flag and if
stdout is connected to a tty.

Signed-off-by: Max Carrara <m.carrara at proxmox.com>

v2 of this little patch incorporates the given feedback[0] (thanks btw!)

Regarding exit codes: Even though it's not too important, I think we
should stick with a non-zero exit code here; at least from what I've
encountered, installation wizards or similar will only exit with 0
if the installation succeeded *or* if the thing to be installed is
already installed. That way subsequent commands are only executed if
the things to be installed are actually there, as further commands
*might* already depend on them, e.g.:

  apt-get install -y neofetch && neofetch

  pveceph install --version quincy && ceph status

This is mostly philosophical, but I've personally found that behaviour
useful in some situations.

[0]: https://lists.proxmox.com/pipermail/pve-devel/2023-July/057993.html

 PVE/CLI/pveceph.pm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm
index b47f8cc1..8cff04c5 100755
--- a/PVE/CLI/pveceph.pm
+++ b/PVE/CLI/pveceph.pm
@@ -176,6 +176,16 @@ __PACKAGE__->register_method ({
 	} else {
 	    die "unsupported ceph version: $cephver";
+	if (-t STDOUT && !$param->{version}) {
+	    print "This will install Ceph " . ucfirst($cephver) . " - continue (y/N)? ";
+	    my $answer = <STDIN>;
+	    my $continue = defined($answer) && $answer =~ m/^\s*y(?:es)?\s*$/i;
+	    die "Aborting installation as requested\n" if !$continue;
+	}
 	PVE::Tools::file_set_contents("/etc/apt/sources.list.d/ceph.list", $repolist);
 	my $supported_re = join('|', $supported_ceph_versions->@*);

More information about the pve-devel mailing list