[pve-devel] [PATCH proxmox-widget-toolkit 1/1] apt: drop ChangeLogUrl

Fabian Grünbichler f.gruenbichler at proxmox.com
Tue Jul 4 11:45:06 CEST 2023


it's not returned anymore by the corresponding backends, since fetching
changelogs is now fully delegated to `apt`.

Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
---

Notes:
    could benefit from a Breaks on old versions of pve-manager/pmg-api ,
    but not strictly required, it will simply allow attempting to fetch
    changelogs for packages where the backend already said there is none

 src/node/APT.js | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/node/APT.js b/src/node/APT.js
index 739aaf3..231e866 100644
--- a/src/node/APT.js
+++ b/src/node/APT.js
@@ -2,7 +2,7 @@ Ext.define('apt-pkglist', {
     extend: 'Ext.data.Model',
     fields: [
         'Package', 'Title', 'Description', 'Section', 'Arch', 'Priority', 'Version', 'OldVersion',
-        'ChangeLogUrl', 'Origin',
+        'Origin',
     ],
     idProperty: 'Package',
 });
@@ -108,8 +108,8 @@ Ext.define('Proxmox.node.APT', {
 	});
 
 	let show_changelog = function(rec) {
-	    if (!rec?.data?.ChangeLogUrl || !rec?.data?.Package) {
-		console.debug('cannot show changelog, missing Package and/or ChangeLogUrl', rec);
+	    if (!rec?.data?.Package) {
+		console.debug('cannot show changelog, missing Package', rec);
 		return;
 	    }
 
@@ -154,7 +154,7 @@ Ext.define('Proxmox.node.APT', {
 	    text: gettext('Changelog'),
 	    selModel: sm,
 	    disabled: true,
-	    enableFn: rec => !!rec?.data?.ChangeLogUrl && !!rec?.data?.Package,
+	    enableFn: rec => !!rec?.data?.Package,
 	    handler: (b, e, rec) => show_changelog(rec),
 	});
 
-- 
2.39.2






More information about the pve-devel mailing list