[pve-devel] [PATCH pve-manager 0/2] ui: fix #3760: change units of ram/swap

Noel Ullreich n.ullreich at proxmox.com
Mon Jul 3 14:08:31 CEST 2023

Ping. Still applies

With me leaving at the end of the month, I want to make sure there is 
plenty of time for my outstanding patches to be reviewed, updated, and 

On 16-06-2023 11:54, Noel Ullreich wrote:
> Up until now, ram, balloonsize and swap were set in MiB, meaning if you wanted to
> create or change a VMs/CTs memory, you would first have to do the math to
> convert from GiB to MiB.
> This patch adds a dropdown-menu of units, MiB, GiB, and TiB, (although
> PiB could easily be added in the future) for ram and swap.
> A future patch in line with this could add units in the API, allowing for
> improved usability from the commandline (e.g. `qm create <id> --memory 2GiB`).
> having `scalingFactor` list in MemoryEdit and Resource Edits might not
> be the most elegant solution, the other option was sticking them in
> `proxmox-widget-toolkit/src/Utils.js` or using the units from there.
> However, if we want to use the units from there, we need to scale them
> and trim the unneeded units. So I thought the least invasive solution
> was to put the `scalingFactor` right in the Files.
> Noel Ullreich (2):
>    ui: fix #3760: change unit of memory of a VM
>    ui: fix: change units of memory/swap for containers
>   www/manager6/lxc/ResourceEdit.js | 136 ++++++++++++++++---
>   www/manager6/qemu/MemoryEdit.js  | 221 +++++++++++++++++++++++--------
>   2 files changed, 285 insertions(+), 72 deletions(-)

More information about the pve-devel mailing list