[pve-devel] [PATCH manager] fix 4481: fetch changelogs for any Proxmox repository

Leo Nunner l.nunner at proxmox.com
Mon Jan 30 11:53:42 CET 2023


On 2023-01-28 14:56, Thomas Lamprecht wrote:
> Am 27/01/2023 um 11:41 schrieb Fabian Grünbichler:
>> a few improvements possible here:
>> - it should be enough that one of the components matches (e.g., I could have
>> pvetest and pve-no-subscription configured in a single entry)
>> - this should only take enabled repositories into account
>> - we should probably also compare the 'Site' member of $pkgfile toe the
>> repository URL
>>
>> since $origin and $component also come from $pkgfile at the call sites, we could
>> maybe just pass in $pkgfile?
>>
>> other than that, this looks okay to me since our components all contain the
>> product, so this allows differentiation :)
> just to be sure: is ceph with it's `test` and `main` covered too?

>From what I can tell: yes, it is. Testing on pacific with the 'test'
repository enabled I get

$base = "dists/bullseye/test/binary-amd64"
$repo->{URIs}[0] = "http://download.proxmox.com/debian/ceph-pacific"

which results in the valid URL

http://download.proxmox.com/debian/ceph-pacific/dists/bullseye/test/binary-amd64/






More information about the pve-devel mailing list