[pve-devel] [PATCH firewall manager] Make firewall config case-insensitive

[Leo Nunner]

Until now, the firewall config was quite inconsistent when it came to
capitalization; groups and ipsets were only allowed in lower-case, while
aliases were allowed to retain the original capitalization.

This patch removes all of these restrictions, and instead keeps the
original user-supplied values for groups, ipsets and aliases.
Furthermore, variable naming for rename parameters was cleaned up (due
to touching these lines anyway) and the docs for them were clarified a
bit.

Optionally, this patch also merges group_comments and ipset_comments
with their groups/ipsets into one unified structure.

firewall:

Leo Nunner (4):
  api: factor out renaming parameters to more descriptive names
  docs: clarify usage of 'rename' parameters
  config: make groups, IPSets and aliases case-insensitive
  config: combine group/ipset and their comments

 src/PVE/API2/Firewall/Aliases.pm |  42 +++++++------
 src/PVE/API2/Firewall/Cluster.pm |   2 +-
 src/PVE/API2/Firewall/Groups.pm  |  63 +++++++++----------
 src/PVE/API2/Firewall/IPSet.pm   |  54 ++++++++--------
 src/PVE/API2/Firewall/Rules.pm   |   4 +-
 src/PVE/API2/Firewall/VM.pm      |   2 +-
 src/PVE/Firewall.pm              | 105 +++++++++++++++++--------------
 7 files changed, 144 insertions(+), 128 deletions(-)

manager:

Leo Nunner (1):
  ui: the API doesn't pass 'name' for aliases anymore

 www/manager6/grid/FirewallAliases.js | 1 +
 1 file changed, 1 insertion(+)

-- 
2.30.2