[pve-devel] [PATCH v3 manager 2/2] ui: backup: replication: replace non-clickable checkbox with icons

[Lukas Wagner]

>From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.

Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
---
 www/manager6/dc/Backup.js        | 6 ++----
 www/manager6/grid/Replication.js | 7 ++++---
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 9d305984..4d12e802 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -785,11 +785,9 @@ Ext.define('PVE.dc.BackupView', {
 		    header: gettext('Enabled'),
 		    width: 80,
 		    dataIndex: 'enabled',
-		    xtype: 'checkcolumn',
+		    align: 'center',
+		    renderer: Proxmox.Utils.renderEnabledIcon,
 		    sortable: true,
-		    disabled: true,
-		    disabledCls: 'x-item-enabled',
-		    stopSelection: false,
 		},
 		{
 		    header: gettext('ID'),
diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js
index b17288b9..1e4e00fc 100644
--- a/www/manager6/grid/Replication.js
+++ b/www/manager6/grid/Replication.js
@@ -279,11 +279,12 @@ Ext.define('PVE.grid.ReplicaView', {
 
 	me.columns = [
 	    {
-		text: gettext('Enabled'),
+		header: gettext('Enabled'),
+		width: 80,
 		dataIndex: 'enabled',
-		xtype: 'checkcolumn',
+		align: 'center',
+		renderer: Proxmox.Utils.renderEnabledIcon,
 		sortable: true,
-		disabled: true,
 	    },
 	    {
 		text: 'ID',
-- 
2.30.2