[pve-devel] applied: [PATCH v2 manager] fix #3037: include the split_list to shell_qoute

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Jan 25 10:30:08 CET 2023


> On 01/25/2023 9:59 AM CET Thomas Lamprecht <t.lamprecht at proxmox.com> wrote:
> 
>  
> Am 25/01/2023 um 09:38 schrieb Wolfgang Bumiller:
> > applied
> > 
> > Though the whole commit message is actually the change log to v1 of the
> > patch and should not have mentioned the `split_list` part at all, only
> > what it actually does and the change list should go below the `---`,
> > please separate these things in the future.
> > 
> 
> but you also applied it as is? I.e., outdated and far from helpful for
> extracting and actual useful d/changelog entry.
> 
> please either amend commit messages on applying, if they're wrong, outdated,
> ..., otherwise reject the patch on that ground.

Yeah sorry about that.





More information about the pve-devel mailing list