[pve-devel] [PATCH manager 2/2] GUI: efi disk: cleanup - var to const

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Jan 20 14:59:37 CET 2023


Am 20/01/2023 um 12:16 schrieb Matthias Heiserer:
>>
>> I'm not that huge fan of applying JavaScript's const broadly to non-scalar values,
>> as it's only a shallow constant and immutable; so no effect on array/object member.
> 
> I quite like const, especially with `const me = this`, because it tells me that I don't have to worry about the variable being reassigned.
> But as long as there's a guideline on whether to use it, I'm happy 😄

Yeah for the `me` (component) this alias it could have some merit;
albeit I'm don't think this was ever an issue in the committed code,
neither during development, but for the latter I naturally can only
speak for myself.


More information about the pve-devel mailing list