[pve-devel] [PATCH widget-toolkit 2/2] repo view: replace non-clickable checkbox with Yes/No text
Lukas Wagner
l.wagner at proxmox.com
Fri Jan 20 12:17:12 CET 2023
>From a usability view, having a checkbox that is not clickable is pretty
misleading, especially if the visual style is exactly the same as in
other places in the UI where the checkbox is functional.
Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
---
src/node/APTRepositories.js | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
index ce8f718..1c4a08c 100644
--- a/src/node/APTRepositories.js
+++ b/src/node/APTRepositories.js
@@ -239,11 +239,10 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', {
columns: [
{
- xtype: 'checkcolumn',
header: gettext('Enabled'),
- dataIndex: 'Enabled',
- listeners: {
- beforecheckchange: () => false, // veto, we don't want to allow inline change - to subtle
+ dataindex: 'Enabled',
+ renderer: function(_a, _b, data) {
+ return data?.data?.Enabled ? Proxmox.Utils.yesText : Proxmox.Utils.noText;
},
width: 90,
},
--
2.30.2
More information about the pve-devel
mailing list