[pve-devel] applied: [PATCH manager v2] ui: storage backup view: Update remove button on protection change
Thomas Lamprecht
t.lamprecht at proxmox.com
Thu Jan 19 18:21:37 CET 2023
Am 19/01/2023 um 10:56 schrieb Christoph Heiss:
> Currently this works in the backup view for containers/VMs, but not in
> the storage backup view. Implement that for the latter part too.
>
> Uses the callback functionality of the load() method of the store to
> properly update the UI as soon as the loading has finished.
> While at it, refactor the same thing in the grid backup view as well,
> removing the current hack in the process.
>
> Signed-off-by: Christoph Heiss <c.heiss at proxmox.com>
>
> ---
> FWIW, using me.store.load({..}) directly in the grid backup view works
> perfectly fine too (as I would expect). But I opted to reuse reload()
> there for now, to keep consistency with the rest of the file. Thus the
> added `options` parameter.
>
> Based on the suggestion in regard to the `var` -> `const`
> transformation, I also converted the callback from an anon-fn to an
> arrow-fn, to further modernize it.
>
> Changes v1 -> v2:
> * Transformed reload() declaration from `var` to `const`
> * Transformed reload() callback to arrow function
> * Renamed `args` parameter to `options`
> * Slightly reworded commit message
>
> v1: https://lists.proxmox.com/pipermail/pve-devel/2023-January/055470.html
>
> www/manager6/grid/BackupView.js | 16 +++++++---------
> www/manager6/storage/BackupView.js | 6 +++++-
> 2 files changed, 12 insertions(+), 10 deletions(-)
>
>
applied, thanks!
More information about the pve-devel
mailing list