[pve-devel] applied-series: [PATCH widget-toolkit/pve-manager] move node selection into combogrid

[Thomas Lamprecht]

Am 18/01/2023 um 14:12 schrieb Dominik Csapak:
> proxmox-widget-toolkit:
> 
> Dominik Csapak (2):
>   ComboGrid: use the grids view for the error message
>   ComboGrid: make height for the error configurable
> 
>  src/form/ComboGrid.js | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> pve-manager:
> 
> Dominik Csapak (6):
>   ui: StorageScanNodeSelector: use null as empty value
>   ui: storage: move node scan selector inside combobox
>   ui: storage/LvmThinInputPanel: modernize & cleanup code
>   ui: storage/IScsiInputPanel: modernize, cleanup & improve panel
>   ui: storage/ZFSPoolInputPanel: modernize & cleanup code
>   ui: storage/LVMInputPanel: modernize & cleanup code
> 
>  www/manager6/form/ComboBoxSetStoreNode.js    |  45 +++-
>  www/manager6/form/StorageScanNodeSelector.js |   8 +-
>  www/manager6/storage/IScsiEdit.js            | 129 +++++++-----
>  www/manager6/storage/LVMEdit.js              | 209 +++++++++++--------
>  www/manager6/storage/LvmThinEdit.js          | 150 +++++++------
>  www/manager6/storage/ZFSPoolEdit.js          | 100 +++++----
>  6 files changed, 361 insertions(+), 280 deletions(-)
> 


nice! applied series with touching up some commit message (subjects) slightly to
my (opinionated) liking, thanks!

as mentioned off-list: currently the outer/main picker is closed unexpected when:
- one wants to close the nested/inner one by clicking somewhere in the outer one.
- the node-selection input field  of the nested-picker has focus and one clicks
  somewhere in the outer/main picker.

It's not a big thing, but otoh: it *is* slightly irritating..