[pve-devel] [PATCH widget-toolkit/pve-manager] move node selection into combogrid

Dominik Csapak d.csapak at proxmox.com
Wed Jan 18 14:12:55 CET 2023


instead of having it as a seperate input on storage creation.
This aims to reduce confusion about what it exactly is and how it
interacts with the rest of the input fields.

With this series, it sits in a toolbar of the relevant dropdown, which
were converted to combogrids. The selection box is only shown if the
number of nodes in the cluster is greater than one.

for accomodating the toolbar, we have to make 2 slight adaptions to the
combogrid

patch 3,4,5,6 of pve-manager are mostly cleanups and are not strictly
necessary for this series to work, but since i touched the files anyway,
i converted them to our 'modern' js style

The cleanups come after the change, because thats the order in which i wrote
it. If wanted i can send the cleanups seperately for the current master,
and rebase the changes for the node selection on top.

proxmox-widget-toolkit:

Dominik Csapak (2):
  ComboGrid: use the grids view for the error message
  ComboGrid: make height for the error configurable

 src/form/ComboGrid.js | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

pve-manager:

Dominik Csapak (6):
  ui: StorageScanNodeSelector: use null as empty value
  ui: storage: move node scan selector inside combobox
  ui: storage/LvmThinInputPanel: modernize & cleanup code
  ui: storage/IScsiInputPanel: modernize, cleanup & improve panel
  ui: storage/ZFSPoolInputPanel: modernize & cleanup code
  ui: storage/LVMInputPanel: modernize & cleanup code

 www/manager6/form/ComboBoxSetStoreNode.js    |  45 +++-
 www/manager6/form/StorageScanNodeSelector.js |   8 +-
 www/manager6/storage/IScsiEdit.js            | 129 +++++++-----
 www/manager6/storage/LVMEdit.js              | 209 +++++++++++--------
 www/manager6/storage/LvmThinEdit.js          | 150 +++++++------
 www/manager6/storage/ZFSPoolEdit.js          | 100 +++++----
 6 files changed, 361 insertions(+), 280 deletions(-)

-- 
2.30.2






More information about the pve-devel mailing list