[pve-devel] applied: [PATCH qemu-server v4 1/2] cd rom handling: return a clearer error when there is no cd rom drive

[Thomas Lamprecht]

Am 20/12/2022 um 11:30 schrieb Stefan Sterz:
> when a vm is configured to use a physical cd rom drive but there is no
> such drive a cryptic "uninitialized value" error is thrown. this is
> due to `$path` being undefined in `sub print_drive_commandline_full`.
> warn that no cd rom drive is available instead.
> 
> note that the error was cosmetic as the vm would start just fine.
> 
> forum thread: https://forum.proxmox.com/threads/119592/
> 
> Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
> ---
> changes from v3 (thanks @ Thomas Lamprecht):
> 
> * use `log_warn` instead of `warn`
> * dont return results of assignments
> 
> changes from v2 (thanks @ Fiona Ebner):
> 
> * added newline to message
> * cache the fact that no drive is available so we warn only once
> * adjusted error message again
> 
> changes from v1: 
> 
> * make the error message more concise. 
> * use shorter forum link for better formatting in commit message 
>   (thanks @ Fiona Ebner).
> 
> 
>  PVE/QemuServer.pm | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
>

applied both patches, thanks!