[pve-devel] applied: [PATCH qemu-server] fix #4435: devices list: avoid error for undefined value

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Jan 11 10:15:11 CET 2023


Am 10/01/2023 um 14:41 schrieb Fiona Ebner:
> When $d->{'pci_bridge'}->{devices} is undef, @-dereferencing it will
> die with:
>> Can't use an undefined value as an ARRAY reference
> 
> This can happen (at least) when the VM is in 'prelaunch' state. The
> QAPI definition for '@PciBridgeInfo' also declares the 'devices'
> member as optional.
> 
> Before commit 721624b ("collect device list for nested pci-bridges"),
> there was no issue, because $d->{'pci_bridge'}->{devices} was used in
> foreach, so auto-vivified if undef.
> 
> Fixes: f721624b ("collect device list for nested pci-bridges")
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
>  PVE/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list