[pve-devel] [PATCH manager/widget-toolkit v6] fix: #3971 Tasklog download button

Daniel Tschlatscher d.tschlatscher at proxmox.com
Wed Jan 4 13:56:32 CET 2023


This patch series' aim is to add a download button in the tasklog-
viewer GUI so that users may access the tasklog more easily.
(The tasklog-viewer only displays 50 lines at a time)
Instead of suddenly returning a file stream when the 'limit' parameter
is set to 0, now, a new parameter 'download' needs to be passed.
This parameter is mutually exclusive with the other parameters.

With the backend patches for pmg and pbs already being applied, these
are the final patches to make the download work.
Therefore, this revision only contains the missing backend patch for
PVE and the GUI patches in the widget-toolkit for the button in the
TaskViewer.

Changes from v5:
* The last version used parameter 'limit=0' instead of 'download=1'
  for the download URL.
* Cleaned up one NIT in manager.

Thanks to sterzy for the review!

pve-manager:

Daniel Tschlatscher (1):
  make task log downloadable in the PVE manager backend

 PVE/API2/Tasks.pm | 49 ++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 42 insertions(+), 7 deletions(-)


proxmox-widget-toolkit:

Daniel Tschlatscher (2):
  Source file download call in central function
  add task log download button in TaskViewer

 src/Utils.js              | 13 +++++++++++++
 src/window/FileBrowser.js | 11 +++++------
 src/window/TaskViewer.js  | 17 +++++++++++++++--
 3 files changed, 33 insertions(+), 8 deletions(-)

-- 
2.30.2






More information about the pve-devel mailing list