[pve-devel] applied: [PATCH zfsonlinux] fix #4440: cherry-pick patch for mountpoint=legacy on /

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Jan 2 17:12:36 CET 2023


Am 02/01/2023 um 15:25 schrieb Stoiko Ivanov:
> As reported having set 'mountpoint=legacy' on the root dataset (for a
> default install this would be 'rpool/ROOT/pve-1') for mounting through
> e.g. /etc/fstab breaks booting in initramfs
> 
> The cherry-picked patch is already applied to zfs-2.1.8-staging
> upstream so will be included in the next zfs point release.
> 
> reproduced the issue on a VM with ZFS on root by:
> * booting into a PVE 7.3 iso (to have zfs and an inactive
>   rpool/ROOT/pve-1)
> * `zpool import -ocachefile=none -N -f rpool
> * `zfs set mountpoint=legacy rpool/ROOT/pve-1`
> * `mount -t zfs rpool/ROOT/pve-1 /mnt
> * `echo "rpool/ROOT/pve-1 / zfs defaults 0 0" >> /mnt/etc/fstab`
> * `zpool export rpool`
> * reboot - the boot breaks with zfs-initramfs 2.1.7-pve1 but works
>   with this patch applied
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
> 
> The current changes on zfs-2.1.8-staging could all be applied without too
> much expected fallout (dracut fixes, aarch64 fixes, tests and testconfig)
> If preferred I can send an update of the zfsmodule to the current tip of this
> branch instead
> 

no, works fine as is. I prefer pulling targeted fixes, at least if coming from
a (unreleased) staging branch/version like here.

>  ...itramfs-Fix-legacy-mountpoint-rootfs.patch | 58 +++++++++++++++++++
>  debian/patches/series                         |  1 +
>  2 files changed, 59 insertions(+)
>  create mode 100644 debian/patches/0012-initramfs-Fix-legacy-mountpoint-rootfs.patch
> 
>

applied, thanks!





More information about the pve-devel mailing list