[pve-devel] [PATCH manager/storage] fix #4289: wait for backup verification to finish before updating volume attribute

Christoph Heiss c.heiss at proxmox.com
Mon Jan 2 13:36:31 CET 2023


When creating a backup to a PBS datastore which has the 'Verify New'
flag set, the backup will fail with an "unable to set protected flag"
error. This is due to the volume being immediately locked by the PBS
server for verifying, before PVE has a chance to set the 'protected'
flag.

Fix this by waiting on the verification job to finish before attempting
to set the volume flag.

[ This is really more of an RFC if it even can be done in this 'naive' way: It
feels a bit hacky, esp. the matching of the `worker_id` value, since this can
be an arbitrary string according to the documentation. Maybe there is a better
way to check for that? Also, should this use some timeout just to be safe? ]

Christoph Heiss (1):
      vzdump: pass logfunc down into storage plugin when updating volume attribute

 PVE/VZDump.pm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Christoph Heiss (1):
      fix #4289: pbs: wait for backup verification to finish before updating volume attribute

 PVE/Storage.pm           |  4 ++--
 PVE/Storage/PBSPlugin.pm | 27 ++++++++++++++++++++++++++-
 2 files changed, 28 insertions(+), 3 deletions(-)





More information about the pve-devel mailing list