[pve-devel] applied: [PATCH v2 qemu-server 1/3] vzdump: Add VM QGA option to skip fs-freeze/-thaw on backup
Thomas Lamprecht
t.lamprecht at proxmox.com
Thu Feb 23 16:36:36 CET 2023
Am 23/02/2023 um 15:18 schrieb Christoph Heiss:
> Signed-off-by: Christoph Heiss <c.heiss at proxmox.com>
> ---
> Changes v1 -> v2:
> * Rename option from 'fsfreeze_thaw' to 'freeze-fs-on-backup'
> * Adapt option description as suggested
> * Fix option check in qga_fs_freeze()
>
> PVE/QemuServer.pm | 8 +++++++-
> PVE/VZDump/QemuServer.pm | 6 ++++++
> 2 files changed, 13 insertions(+), 1 deletion(-)
>
>
applied, thanks!
FWIW, I forgot to write in my review of v1 that having the disabled-in-config
check done before the is-qga-running one would have felt _slightly_ more sensible
to me, as no use in checking for availability of a service if one isn't going
to use it anyway - but, this is only a small nit and could be easily addressed
anytime - so mostly mentioning it to get it off my mind ;-)
More information about the pve-devel
mailing list