[pve-devel] [PATCH qemu-server] start: make not being able to set polling interval for ballooning non-critical

Fiona Ebner f.ebner at proxmox.com
Thu Feb 23 10:49:03 CET 2023


The guest will be running, so it's misleading to fail the start task
here. Also ensures that we clean up the hibernation state upon resume
even if there is an error here, which did not happen previously[0].

[0]: https://forum.proxmox.com/threads/123159/

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
 PVE/QemuServer.pm | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index a1a8b937..ff1e3c72 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -6053,13 +6053,16 @@ sub vm_start_nolock {
     }
 
    if (!defined($conf->{balloon}) || $conf->{balloon}) {
-	mon_cmd(
-	    $vmid,
-	    'qom-set',
-	    path => "machine/peripheral/balloon0",
-	    property => "guest-stats-polling-interval",
-	    value => 2
-	);
+	eval {
+	    mon_cmd(
+		$vmid,
+		'qom-set',
+		path => "machine/peripheral/balloon0",
+		property => "guest-stats-polling-interval",
+		value => 2
+	    );
+	};
+	log_warn("could not set polling interval for ballooning - $@") if $@;
     }
 
     if ($resume) {
-- 
2.30.2






More information about the pve-devel mailing list