[pve-devel] applied-series: [PATCH manager v3 0/6] fix #1408: ui: make tree sorting configurable

[Thomas Lamprecht]

Am 22/02/2023 um 08:51 schrieb Dominik Csapak:
> this series allows configuring the sorting of the resource tree
> 
> options are the sort-field, if guest types are grouped and if templates
> are grouped seperately. it's configurable via browser local storage
> 
> the first 2 patches are not really related but popped up during
> development
> 
> changes from v2:
> * improved browser local storage notice
> * added padding between the view selector and the button
> 
> changes from v1:
> * drop the datacenter config options for now
> * rename TreeSortingEdit into TreeSortingEdit
> * since we don't have a fallback besides the default, display the
>   defauls in the dropdowns
> * don't use booleanfield anymore (because of above change)
> * rename sp into localStorage
> * use fieldDefaults
> * refactor stuff into PVE.UIOptions (a new singleton)
> * remove storage view
> * remove booleanfield()
> 
> Dominik Csapak (6):
>   ui: remove 'Storage View'
>   ui: remove unused booleanfield
>   ui: refactor ui option related methods into UIOptions
>   ui: refactor refreshing the the resource store/tree
>   ui: add window for changing tree related options
>   fix #1408: ui: ResourceTree: sort the tree according to tree-sorting
>     options
> 

applied, thanks!

As talked off-list, I made three small followups
1) make settings button stand less out
2) making window a bit wider and claryfing the field labels (mostly that the
   type grouping only affects guests)
3) change the bogus url to '#'

for the record only, as we also talked off list: it might be nice to apply
changes live, so that one can see the effect in the background already.

But the current settings are relatively straight forward and after initial
setup its unlikely to change, so there's not _that_ much friction as is.