[pve-devel] [PATCH http-server 0/2] refactor HTTP request processing

Max Carrara m.carrara at proxmox.com
Fri Feb 17 16:25:15 CET 2023

This patch series refactors the request processing algorithm by
separating its data and logic from one another in order to make future
changes regarding requests more transparent and explicit.

Patch 1: Introduce the refactored algorithm
Patch 2: Replace and remove the existing algorithm with the new one

This refactor is conducted very carefully to ensure that none of the
existing behaviours change in any way. One exception however would be
the reading of the HTTP header itself: Instead of reading the
header by recursively appending / prepending callbacks to the handle's
and reading the header line-by-line, the entire header is read at
once, reducing the number of callbacks needed to parse the header from
the number of lines to one. This affects when the header line count
and size limits are checked - instead of being checked *while* the
header is being read, these limits are verified *after* the header
was read from the read buffer. If this change in behaviour is
undesirable, I'll gladly provide a v2.

Otherwise, the behaviour is identical; the logic is restructured,
but entirely preserved.

To give a more concrete example of what these changes would make more
transparent, the enhancement requested in #4494[1] would become just
another step (-> subroutine) in the refactored algorithm. That way it
becomes much clearer where the TLS handshake is being verified
and which responses (e.g. a `301`) are sent in case the handshake
never happened or was aborted.

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=4494


Max Carrara (2):
  http-server: anyevent: add new subroutine for processing requests
  http-server: anyevent: replace request processing subroutine

 src/PVE/APIServer/AnyEvent.pm | 671 ++++++++++++++++++++++------------
 1 file changed, 445 insertions(+), 226 deletions(-)


More information about the pve-devel mailing list