[pve-devel] [PATCH container 1/2] net: Add `link_down` config to allow setting interfaces as disconnected
Thomas Lamprecht
t.lamprecht at proxmox.com
Tue Feb 14 11:20:14 CET 2023
On 14/02/2023 11:10, Christoph Heiss wrote:
>> besides from that, the patch here contains quite some unrelated whitespace
>> changes, please avoid that.
> That was intentional (as noted), since there are trailing whitespaces
> all over the file, which can be somewhat annoying if one's editor
> automatically trims trailing whitespaces on save purposefully.
> But I will omit that from the next revision, fine by me.
I never said that fixing it is wrong, but it's completely unrelated for
your change, and thus noise - please do that in a separate patch upfront
for the next revision, then it could have been already applied now ;-)
More information about the pve-devel
mailing list