[pve-devel] [PATCH qemu-server 1/4] hotplug: disk: mark aio as non-hotpluggable

Fiona Ebner f.ebner at proxmox.com
Fri Feb 10 15:19:09 CET 2023


Previously, changing aio would be applied to the configuration, but
the drive would still be using the old setting.

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
 PVE/QemuServer.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index a0e16dcd..6130fe82 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -5388,7 +5388,8 @@ sub vmconfig_update_disk {
 		# update existing disk
 
 		# skip non hotpluggable value
-		if (safe_string_ne($drive->{discard}, $old_drive->{discard}) ||
+		if (safe_string_ne($drive->{aio}, $old_drive->{aio}) ||
+		    safe_string_ne($drive->{discard}, $old_drive->{discard}) ||
 		    safe_string_ne($drive->{iothread}, $old_drive->{iothread}) ||
 		    safe_string_ne($drive->{queues}, $old_drive->{queues}) ||
 		    safe_string_ne($drive->{cache}, $old_drive->{cache}) ||
-- 
2.30.2






More information about the pve-devel mailing list