[pve-devel] applied: [PATCH storage 1/1] fix #2641: allow mounting of CIFS subdirectories

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Feb 7 15:58:02 CET 2023

Am 01/12/2022 um 12:32 schrieb Leo Nunner:
> CIFS/SMB supports directly mounting subdirectories, so it makes sense to
> also allow the --subdir parameter for these storages. The subdir
> parameter was moved from CephFSPlugin.pm to Plugin.pm, because it isn't
> specific to CephFS anymore.
> Signed-off-by: Leo Nunner <l.nunner at proxmox.com>
> ---
>  PVE/Storage/CIFSPlugin.pm   | 39 ++++++++++++++++++++-----------------
>  PVE/Storage/CephFSPlugin.pm |  4 ----
>  PVE/Storage/Plugin.pm       |  5 +++++
>  3 files changed, 26 insertions(+), 22 deletions(-)

the patch does more at once than ideal, I'd recommend doing such things as the
signature cleanups, which should not have any change functional effect after all,
first - that simplify review and also working with the history (e.g., bisect or just
wanting to see how a specific feature was done if adding a similar one).

But this was relatively minor crowding here, and I did not wanted to delay this
further... so applied, with some cleanups as follow up, thanks!

ps. the safer fallback for $subdir would have been a empty string '', as then it'd
be 1:1 the exact same value as before if one doesn't have any subdir configured -
but lets hope no cifs client/server throws up on a newly added trailing slash.

More information about the pve-devel mailing list