[pve-devel] [PATCH manager 1/2] ui: dc: backup: improve UX for the different 'notification-mode's

Maximiliano Sandoval m.sandoval at proxmox.com
Thu Dec 14 11:26:44 CET 2023


Lukas Wagner <l.wagner at proxmox.com> writes:

>   - Switch order of 'mailto' and 'mailnotification' field
>   - When mode is 'auto', disable 'mailtnotification' field
>   - When mode is 'auto' and 'mailto' is empty, show
>     hint that the notification system will be used
>
> Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>

Tested both commits, they do what they promise.

> +	let notificationSystemHint = Ext.create({
> +	    xtype: 'displayfield',
> +	    padding: '0 0 0 5',
> +	    userCls: 'pmx-hint',
> +	    hidden: true,
> +	    value: gettext('No email configured, the notification system will be used'),
> +	    viewModel,
> +	    bind: {
> +		hidden: '{!hintTextVisible}',

I think the `pmx-hint` being displayed as yellow suggests it is a
warning/error rather than a hint. I wonder if there is a better
approach, as this is certainly not a warning.

Tested-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
--
Maximiliano




More information about the pve-devel mailing list