[pve-devel] applied: [PATCH manager v4 0/2] fix #474: allow transfer from container/vms

[Thomas Lamprecht]

Am 30/08/2023 um 14:53 schrieb Philipp Hufnagl:
> On 8/24/23 16:46, Thomas Lamprecht wrote:
>> And I agree with Dominik, UX isn't ideal, a warning that one or more VMID will
>> be moved out of there old Pool, if any, would be sufficient. Not sure if it'd be
>> better if that's a per-row hint, shown if the row is ticked (e.g., instead of the
>> Pool column) or a edit-window wide warning hint that gets made visible if any of
>> the selected VMIDs is in a Pool already.
>>
>> FWIW, and not directly related (i.e., can be it's own series), you could also fix
>> the s/Virtual Machine/Virtual Guest/ wording to avoid the confusion that one also
>> adds Container over this interface.
> 
> Sorry for the issue. It has been my first Patch on this scale.

Yeah, here to "blame" (exaggeration) is also Wolfgang applying the UI
side IMO a bit prematurely, without consulting Dominik or me for UX.

But it's still all the more important to be reactive to feedback
especially when starting out, otherwise reviewers might stop giving it
if they feel it's not heard anyway.

> As for the feature design itself: The UI could be improved by only showing vms assinged to a pool when the transfer/migrade check box is checked. This way it should be clear if it is a migration without the use of a popup.
> 
> Would that work? Feedback is most welcome :)


IMO that's a bit convoluted and still needs an extra step, as Dominik
and I both, rather avoid the checkbox completely.