[pve-devel] applied: [PATCH v2 widget-toolkit] fix #4531: Fix ACME plugin edit form not detecting changes

[Thomas Lamprecht]

Am 30/08/2023 um 13:57 schrieb Filip Schauer:
> Fix the ACME plugin edit form only detecting dirtychanges once the value
> of a textfield was dirtied and then changed back to the original.
> 
> This behaviour is caused by setting the originalValue directly without
> calling checkDirty. The reason is that the dirty flag of the textfield
> is set to true by setValue, and then not reset to false even though the
> value matches the original value. This is fixed by calling checkDirty
> after setting the originalValue to refresh the dirty flag.
> 
> Signed-off-by: Filip Schauer <f.schauer at proxmox.com>
> ---
> Changes since v1:
> * Fix introduced bug that would set a dirty value as the original one
>   when switching plugins.
> * Improve the commit message
> 
>  src/window/ACMEPluginEdit.js | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, slightly reworded the commit message, a few subjective nits but
also recording the actual reason we do it this way by using Dominik's example
from his reply to the v1 thread, thanks!