[pve-devel] [PATCH manager v2] fix #4634: ui: osd: allow to translate the entire string

Maximiliano Sandoval m.sandoval at proxmox.com
Mon Aug 28 17:54:59 CEST 2023


Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---
xgettext supports extracting comments so I added a comment to make it future
proof. Note though our tooling (proxmox-i18n) strips them. I hope to send a patch fixing
this soon.

Differences from v1:
  - Use format instead of relying on a translator comment.

 www/manager6/ceph/OSD.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
index d2caafa4..242674fb 100644
--- a/www/manager6/ceph/OSD.js
+++ b/www/manager6/ceph/OSD.js
@@ -233,7 +233,8 @@ Ext.define('PVE.CephSetFlags', {
 
     onlineHelp: 'pve_ceph_osds',
     isCreate: true,
-    title: Ext.String.format(gettext('Manage {0}'), 'Global OSD Flags'),
+    // TRANSLATORS: This will read 'Manage Global OSD Flags'.
+    title: Ext.String.format(gettext('Manage Global {0} Flags'), 'OSD'),
     submitText: gettext('Apply'),
 
     items: [
@@ -837,7 +838,7 @@ Ext.define('PVE.node.CephOsdTree', {
 		handler: 'create_osd',
 	    },
 	    {
-		text: Ext.String.format(gettext('Manage {0}'), 'Global Flags'),
+		text: gettext('Manage Global Flags'),
 		handler: 'set_flags',
 	    },
 	    '->',
-- 
2.39.2






More information about the pve-devel mailing list