[pve-devel] [PATCH v2 qemu-server] fix #3963: Skip TPM startup for template VMs
Filip Schauer
f.schauer at proxmox.com
Wed Aug 9 11:35:54 CEST 2023
I messed up the formatting the formatting there. What I meant to say:
Changes since v1:
* Add a missing not sign in front of the is_template check
> On 09.08.2023 11:22 CEST Filip Schauer <f.schauer at proxmox.com> wrote:
>
>
> Skip the software TPM startup when starting a template VM for performing
> a backup. This fixes an error that occurs when the TPM state disk is
> write-protected.
>
> Signed-off-by: Filip Schauer <f.schauer at proxmox.com>
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index 484bc7f..c262c68 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -5923,7 +5923,7 @@ sub vm_start_nolock {
> PVE::Systemd::enter_systemd_scope($vmid, "Proxmox VE VM $vmid", %systemd_properties);
>
> my $tpmpid;
> - if (my $tpm = $conf->{tpmstate0}) {
> + if ((my $tpm = $conf->{tpmstate0}) && !PVE::QemuConfig->is_template($conf)) {
> # start the TPM emulator so QEMU can connect on start
> $tpmpid = start_swtpm($storecfg, $vmid, $tpm, $migratedfrom);
> }
> --
>
> Whoops, missed a not in front of the is_template check.
>
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
More information about the pve-devel
mailing list