[pve-devel] applied: [PATCH] fixes #4874: Raise error for hostname

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Aug 3 10:53:47 CEST 2023


Am 03/08/2023 um 03:04 schrieb Amin Vakil:
> Current error message is not correct because having underscores in domain names are perfectly valid, although it's not acceptable at host names, so it should be changed to "This is not a valid hostname".
> 
> https://www.ietf.org/rfc/rfc1123.txt section 2.1 "Host Names and Numbers"
> https://www.rfc-editor.org/rfc/rfc2181#section-11
> 
> Signed-off-by: Amin Vakil <info at aminvakil.com>
> ---
>  src/Toolkit.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!

FYI, I amended the commit as there was still a "wrong" instance of "Host name"
that I replaced with "hostname", and reflowed the commit message so that it uses
70 characters per line as per our commit message style guide:
https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages





More information about the pve-devel mailing list