[pve-devel] [PATCH manager 2/3] ui: make storage backup content stateful

Thomas Lamprecht t.lamprecht at proxmox.com
Sat Apr 22 09:21:39 CEST 2023

On 20/04/2023 10:06, Dominik Csapak wrote:
> so that e.g. a custom sort/column order is saved
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  www/manager6/storage/BackupView.js | 3 +++
>  1 file changed, 3 insertions(+)
> diff --git a/www/manager6/storage/BackupView.js b/www/manager6/storage/BackupView.js
> index 9ad1a4915..bb045f5b6 100644
> --- a/www/manager6/storage/BackupView.js
> +++ b/www/manager6/storage/BackupView.js
> @@ -5,6 +5,9 @@ Ext.define('PVE.storage.BackupView', {
>      showColumns: ['name', 'notes', 'protected', 'date', 'format', 'size'],
> +    stateful: true,
> +    stateId: 'storage-backup-content',

I'm not the biggest fan of stateful grids, if it would only save sorting
it would be OK (can easily be done, but needs to be done manual IIRC), but
by default much more state is saved and reapplied. E.g. the grid column
flex'd widths are then also easily made fixed. Personally I quite often use
the "Reset Layout" just due to that, after having my browser resized and the
columns not adapting in a responsive way – one also cannot clear the state
in a fine grained way, neither by component (at least not easily by changing
to a per, e.g. for here, stateful ID that includes the storage ID) nor by
single thing, like sort order (e.g., a user has no simple way to know what
the original sort order, deemed as best by the devs, was).

> +
>      initComponent: function() {
>  	let me = this;

More information about the pve-devel mailing list