[pve-devel] [PATCH pve-manager 0/1] fixing gettext problems

Daniel Koć daniel at xn--ko-wla.pl
Sun Apr 16 05:29:38 CEST 2023


I wanted to make the translation of Proxmox apps more complete and
there are multiple places where gettext() is missing. I would be 
happy to add it wherever possible to give translators more power,
but I'd like to fix at least most visible gaps. Here is my first try
to do that.

I'm not a developer and I don't plan to be one, so it's hard for me
to do everything properly. Especially I did not test the changes,
since instructions to make devel environment look pretty complex to
me. If there is a quick way to easily update JS and POT files on
running PVE environment, I would be happy to use it.

There are some cases where gettext blocks are already here, but are
not visible, so it would be good to fix that too, but I don't know
how. Examples from fresh PVE 7.4-3 installation:

- native language names are not visible on the login page and in the
  top right menu, even if they are translated
- Hint "Without any keep option, the storage's configuration or 
  node's vzdump.conf is used as fallback" is already gettextized in
  www/manager6/dc/Backup.js, but I see original string instead
Any comments are welcome.

Daniel Koć (1):
  adding missing gettext

 www/manager6/ceph/FS.js         | 4 ++--
 www/manager6/ceph/OSD.js        | 6 +++---
 www/manager6/ceph/OSDDetails.js | 2 +-
 www/manager6/form/VLanField.js  | 2 +-
 www/manager6/ha/Fencing.js      | 4 ++--
 www/manager6/ha/GroupEdit.js    | 2 +-
 www/manager6/node/Config.js     | 2 +-
 7 files changed, 11 insertions(+), 11 deletions(-)


More information about the pve-devel mailing list