[pve-devel] applied: [PATCH manager] api: ceph: mon create: remove superfluous verification call

Thomas Lamprecht t.lamprecht at proxmox.com
Wed Apr 12 13:27:29 CEST 2023

Am 03/04/2023 um 11:35 schrieb Fiona Ebner:
> The pve_verify_cidr{,v4,v6} functions were originally intended for
> the /etc/network/interfaces API endpoints and thus are a bit
> restrictive. For example, as reported in the community forum[0],
> pve_verify_cidr() does not consider '0::/0' and '0::/1' to be valid.
> The error message in this scenario being
>> value does not look like a valid CIDR network
> is also confusing, as the first thought of users will be that it comes
> from the passed-in monitor address.
> The public networks are not written here and read from the Ceph config
> and via a RADOS mon command, so no need to try and verify them. If
> something really would go wrong during parsing, the
> get_local_ip_from_cidr() call would complain afterwards.
> [0]: https://forum.proxmox.com/threads/125226/
> Suggested-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
>  PVE/API2/Ceph/MON.pm | 4 ----
>  1 file changed, 4 deletions(-)

applied, thanks!

More information about the pve-devel mailing list