[pve-devel] applied: [PATCH v2 edk2-firmware] fix #4625: restore SMBIOS type 0 table defaults

[Thomas Lamprecht]

Am 30/03/2023 um 13:01 schrieb Fiona Ebner:
> Commit 4cb94f20b0 ("OvmfPkg/SmbiosPlatformDxe: use PcdFirmware*") in
> the edk2 submodule made the switch from hard coded values for the
> SMBIOS type 0 table to using those defined in the PCD (Platform
> Configuration Database). But this changed the value for the vendor
> from "EFI Development Kit II / OVMF" to "EDK II" and made version and
> release date "unknown". This can cause problems for hardware keys[0],
> and the missing date can make Windows unhappy[1].
> 
> The PCD information can be specified during build. For the vendor,
> just revert to the hardcoded value from before. This should be enough
> to resolve the issue in [0]. For version and date, use sensible values
> gathered from the build variables. The date format is mm/dd/yyyy while
> the version is free-form according to [2], section 7.1.
> 
> [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=4625
> [1]: https://edk2.groups.io/g/devel/message/100922
> [2]: https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3.2.0.pdf
> 
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> 
> Changes from v1:
>     Based on the discussion in [3] and the fact that the user from bug
>     #4625 reportet that it's enough to keep the vendor the same:
>     * Add trailing null character to strings, just to be sure.
>     * Set version and date to sensible values generated during build.
>       This was the intention behind commit 4cb94f20b0 in the first
>       place.
> 
> [3]: https://edk2.groups.io/g/devel/message/102164
> 
>  debian/rules | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
>

applied, thanks!