[pve-devel] [PATCH qemu-server 1/4] cfg2cmd: use actual backend names instead of removed tty and paraport aliases

Fiona Ebner f.ebner at proxmox.com
Mon Apr 3 14:09:42 CEST 2023


As described in:
https://qemu-project.gitlab.io/qemu/about/removed-features.html#chardev-backend-aliases-tty-and-parport-removed-in-8-0

Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
 PVE/QemuServer.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index c1d0fd2d..c7caa163 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -3794,7 +3794,7 @@ sub config_to_command {
 	    }
 	} else {
 	    die "no such serial device\n" if ! -c $path;
-	    push @$devices, '-chardev', "tty,id=serial$i,path=$path";
+	    push @$devices, '-chardev', "serial,id=serial$i,path=$path";
 	    push @$devices, '-device', "isa-serial,chardev=serial$i";
 	}
     }
@@ -3803,7 +3803,7 @@ sub config_to_command {
     for (my $i = 0; $i < $MAX_PARALLEL_PORTS; $i++)  {
 	if (my $path = $conf->{"parallel$i"}) {
 	    die "no such parallel device\n" if ! -c $path;
-	    my $devtype = $path =~ m!^/dev/usb/lp! ? 'tty' : 'parport';
+	    my $devtype = $path =~ m!^/dev/usb/lp! ? 'serial' : 'parallel';
 	    push @$devices, '-chardev', "$devtype,id=parallel$i,path=$path";
 	    push @$devices, '-device', "isa-parallel,chardev=parallel$i";
 	}
-- 
2.30.2






More information about the pve-devel mailing list