[pve-devel] [PATCH qemu-server v4 0/2] qmeventd: improve shutdown behaviour

Dominik Csapak d.csapak at proxmox.com
Fri Sep 23 11:51:13 CEST 2022


includes the following improvements:
* increases 'force cleanup' timeout to 60s (from 5)
* saves individual timeout for each vm
* don't force cleanup for vms where normal cleanup worked
* sending QMP quit instead of SIGTERM (less log noise)

changes from v3:
* merge CleanupData into Client (pidfd,timeout) and use that for the
   forced_cleanup list
* close pidfd also in cleanup_client (and remove itself from the
   forced_cleanup list)
* guard the sigkill with a check for timeout != 0
* with those changes patch 2/3 is not necessary anymore

changes from v2:
* change from cast of the function to cast of the parameters
* don't copy the variable on the stack in 'sigkill'

changes from v1:
* remove 'alarm' calls altogether and use epoll_waits' timeout mechanic
   instead
* call 'time()' only once and give it as user data to the function
* change the function singatures and cast on callsite with '(GFunc)'
   for the g_slist_foreach calls
* change to <s> for the usage output for timeouts

Dominik Csapak (2):
  qmeventd: rework 'forced_cleanup' handling and set timeout to 60s
  qmeventd: send QMP 'quit' command instead of SIGTERM

 qmeventd/qmeventd.c | 112 ++++++++++++++++++++++++--------------------
 qmeventd/qmeventd.h |   8 ++--
 2 files changed, 65 insertions(+), 55 deletions(-)

-- 
2.30.2






More information about the pve-devel mailing list