[pve-devel] [PATCH qemu-server 1/3] qmeventd: rework 'forced_cleanup' handling and set timeout to 60s

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Sep 22 13:51:52 CEST 2022


Am 21/09/2022 um 14:49 schrieb Dominik Csapak:
> +    fprintf(stderr, "  -t timeout   kill timeout (default: %ds)\n", DEFAULT_KILL_TIMEOUT);

just a nit, as you probably send a v2 for Fabian's comments anyway:

Please do s/timeout/<s>/ i.e.:

-t <s> kill timeo..

That has two advantages, first the user actually knows the time unit and
second, the context whitespace changes aren't required anymore.

Did not checked the rest more closely, but this stuck out when skimming.





More information about the pve-devel mailing list