[pve-devel] [PATCH guest-common] replication: avoid "expected snapshot missing warning" when irrelevant

Fiona Ebner f.ebner at proxmox.com
Thu Sep 22 13:13:03 CEST 2022


Am 22.09.22 um 13:00 schrieb Fiona Ebner:
> Namely, when there are no snapshots at all on the volume, which also
> is the case when the volume doesn't exist. This happens when a fresh
> volume is added to an already replicated guest.

The warning still triggers, when some other snapshot is added to the new
disk before the replication runs (by taking a snapshot or via another
replication). I'll send a v2 and print the warning only when there's
actually another replication snapshot that would've been removed without
the safeguard added by c0b2948.

> 
> Fixes replication tests in pve-manager, which didn't like the additional
> output.
> 
> Fixes: c0b2948 ("replication: prepare: safeguard against removal if expected snapshot is missing")





More information about the pve-devel mailing list