[pve-devel] applied: [PATCH qemu-server] cleanup pci devices in more situations

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Sep 20 13:55:26 CEST 2022


Am 27/07/2022 um 15:28 schrieb Dominik Csapak:
> if the preparing of pci devices or the start of the vm fails, we need
> to cleanup the pci devices (reservations *and* mdevs), or else
> it might happen that there are leftovers which must be manually removed.
> 
> to include also mdevs now, refactor the cleanup code from 'vm_stop_cleanup'
> into it's own function, and call that instead of only 'remove_pci_reservation'
> 
> also print the errors of the cleanup steps with 'warn', otherwise we
> might discard important errors
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  PVE/QemuServer.pm | 40 ++++++++++++++++++++++++----------------
>  1 file changed, 24 insertions(+), 16 deletions(-)
> 
>

applied, thanks!

fyi, there where some context changes but `git am -3` managed to auto-merge just
fine, so hopefully I did not overlook some problematic (semantic) changes for
this.





More information about the pve-devel mailing list