[pve-devel] [PATCH manager v7 10/14] ui: tree/ResourceTree: show Tags in tree

[Dominik Csapak]

On 9/14/22 16:15, Aaron Lauterer wrote:
> Why the change from vm.text to vm_text in {lxc,qemu}/Config.js?
> 
> AFAICT we have exactly the same string in the now not used "vm.text".
> 
> If these changes are needed and should be part of this commmit, a short explanation would be good as 
> it does not seem to have anything to do with the resource tree.

you're right in that the explanation is missing:

to show the tags in the tree, we have to modify the text in those records, which are passed
through to the components and end up in 'vm.text', so the tags would end up there

but since we want the tags to be shown differently there (to be able to add/edit them)
we cannot use that anymore

> 
> On 6/21/22 11:20, Dominik Csapak wrote:
[snip]
>>           node: {
>> @@ -114,6 +116,8 @@ Ext.define('PVE.tree.ResourceTree', {
>>           }
>>       }
>> +    info.text += PVE.Utils.renderTags(info.tags, PVE.Utils.tagOverrides);
>> +
>>       info.text = status + info.text;
>>       },


here we modify the 'text' property