[pve-devel] [PATCH manager v7 07/14] ui: add form/Tag

Aaron Lauterer a.lauterer at proxmox.com
Wed Sep 14 16:36:20 CEST 2022


I have to follow up here as I noticed that in a private Firefox window it did 
work much better and as expected. I suspect some addon is interfereing here. 
Which one I cannot say yet.

On 9/14/22 16:15, Aaron Lauterer wrote:
> This component seems to not be working as expected.
> 
> In Firefox (105.0) I get all kinds of glitches and investigating it a bit, it 
> seems like the HTML & CSS classes manipulation doesn't seem to work correctly. 
> For example, if I edit an existing tag and select another existing one from the 
> appearing drop down menu, the tag has a different set of HTML tags than before.
> 
> The "Add tag" button also seems somewhat broken in that regard, e.g. showing the 
> plus icon more than once.
> 
> 
> On Chromium (105.0.5195.102), I noticed, that I cannot select a pre-existing tag 
> when adding a new or editing an existing tag, but the tags themselves look okay.
> 
> I would also recommend that we do test this in Safari and Edge (the officially 
> supported browser).
> 
> 
> On 6/21/22 11:20, Dominik Csapak wrote:
>> displays a single tag, with the ability to edit inline on click (when
>> the mode is set to editable). This brings up a list of globally available tags
>> for simple selection.
>>
>> Also has a mode for adding a new Tag.
>>
>> This has a 'layoutCallback' which will be called on input, so that the parent
>> component can update the layout when the content changes.
>> This is necessary since we circumvent the extjs logic for updating.
>>
>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
>> ---
>>   www/manager6/Makefile    |   1 +
>>   www/manager6/form/Tag.js | 276 +++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 277 insertions(+)
>>   create mode 100644 www/manager6/form/Tag.js
>>
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 





More information about the pve-devel mailing list