[pve-devel] applied: [PATCH widget-toolkit] fix: toolkit: make email regex pattern match pve-common

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Sep 12 17:15:34 CEST 2022


Am 07/09/2022 um 11:37 schrieb Stefan Sterz:
> `proxmoxMail` used its own regex pattern to validate emails. that
> meant certain email addresses were rejected by the front-end that
> were accepted by the backend that uses the functionality from
> `pve-common`. examples include the following:
> 
> - "user at host.test-tld"
> - "user- at host.testtld"
> - "user at host"
> 
> reported on the forum: https://forum.proxmox.com/threads/gui-bugulance-using-the-user-add-gui-interface.114743/
> 
> Signed-off-by: Stefan Sterz <s.sterz at proxmox.com>
> ---
> note that there are many many regex patterns that could be used
> (e.g.: [1]). im partial to w3c's approach [2], mainly because it's
> likely to be widely used, while being fairly simple and compatible
> with perl and javascript.
> 
> [1]: https://www.ex-parrot.com/~pdw/Mail-RFC822-Address.html
> [2]: https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address
> 
>  src/Toolkit.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list