[pve-devel] applied: [PATCH v3 qemu] init: daemonize: defuse PID file resolve error

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Oct 28 10:59:08 CEST 2022


On 28/10/2022 10:09, Fiona Ebner wrote:
> When proxmox-file-restore invokes QEMU, the PID file is a (temporary)
> file that's already unlinked, so resolving the absolute path here
> failed.
> 
> It should not be a critical error when the PID file unlink handler
> can't be registered, because the path can't be resolved for whatever
> reason. If the file is already gone from QEMU's perspective (i.e.
> errno is ENOENT), silently ignore the error. Otherwise, print a
> warning.
> 
> Reported-by: Dominik Csapak <d.csapak at proxmox.com>
> Suggested-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
> 
> Changes from v2:
>     * Be quiet when error is ENOENT.
> 
>  softmmu/vl.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
>

applied, thanks!





More information about the pve-devel mailing list