high level looks mostly good, a small question: is there a special reason why we ignore pre-lvm osds here? AFAICS, we simply error out for osds that don't live on lvm (though we can add additional types later i guess) comments in the individual patches