[pve-devel] [PATCH-SERIES docs/(guest-)common/qemu-server/container/manager] cpuunits improvements
Fiona Ebner
f.ebner at proxmox.com
Fri Oct 7 14:41:37 CEST 2022
This series does multiple things, all related to cpuunits:
* Updates the documentation in pve-docs and pve-container for the
cgroup v2 cpuunits defaults and limits, while still mentioning the old
values that apply to legacy cgroup v1 hosts. qemu-server is already
updated.
* Move the get_cpuunits() helper from qemu-server to guest-common and
re-use it for containers. Makes behavior consistent with VMs and
allows starting existing containers with an out-of-range value. This
requires dependency bumps qemu-server,pve-container -> guest-common.
* Drop an unused parameter for change_cpu_shares(). Here technically,
a Breaks from common -> pve-container,qemu-server is needed, before
we can introduce a new parameter.
* Clamp cpuunits value already when setting via API.
* Broadcast the node's cgroup version as a pmxcfs kv entry. This is
the v2 of that patch, changes are noted there and use the value in
the UI to dynamically show the correct defaults and limits.
docs:
Fiona Ebner (2):
qm: resource limits: update systemd setting name for cpuunits
pct/qm: update cpuunits default
pct.adoc | 5 +++--
qm.adoc | 14 +++++++-------
2 files changed, 10 insertions(+), 9 deletions(-)
guest-common
Fiona Ebner (1):
helpers: move get_cpuunits helper from qemu-server
src/PVE/GuestHelpers.pm | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
container:
Fiona Ebner (7):
config: cpuunits: drop description for outdated special value
change cpu shares: hard-code cgroupv1 default parameter
config: cpuunits: update default description
use helper from guest-common for cpuunits
config: replace mentions of "VM" with "container"
change cpu shares: drop superfluous parameter
api: create/update vm: clamp cpuunit value
src/PVE/API2/LXC.pm | 3 +++
src/PVE/API2/LXC/Config.pm | 4 ++++
src/PVE/LXC.pm | 5 ++---
src/PVE/LXC/Config.pm | 19 +++++++++++--------
4 files changed, 20 insertions(+), 11 deletions(-)
qemu-server:
Fiona Ebner (3):
move get_cpuunits helper to guest-common
change cpu shares: drop superfluous parameter
api: create/update vm: clamp cpuunit value
PVE/API2/Qemu.pm | 6 ++++++
PVE/QemuServer.pm | 23 ++++-------------------
2 files changed, 10 insertions(+), 19 deletions(-)
common:
Fiona Ebner (1):
change cpu shares: drop unused $cgroupv1_default parameter
src/PVE/CGroup.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
manager:
Fiona Ebner (5):
ui: lxc: cpu edit: drop superfluous delete_if_default
ui: qemu/lxc: cpu edit: fix 'create' parameter for delete_if_default()
ui: lxc/qemu: cpu edit: use emptyText for cpuunits
cluster resources: add cgroup-mode to node properties
ui: lxc/qemu: cpu edit: make cpuunits depend on node's cgroup version
PVE/API2/Cluster.pm | 12 +++++++++
PVE/Service/pvestatd.pm | 16 ++++++++++++
www/manager6/lxc/CreateWizard.js | 8 ++++++
www/manager6/lxc/ResourceEdit.js | 39 +++++++++++++++++++++++-------
www/manager6/lxc/Resources.js | 8 +++++-
www/manager6/qemu/CreateWizard.js | 8 ++++++
www/manager6/qemu/HardwareView.js | 8 +++++-
www/manager6/qemu/ProcessorEdit.js | 34 ++++++++++++++++++++------
8 files changed, 114 insertions(+), 19 deletions(-)
--
2.30.2
More information about the pve-devel
mailing list